Skip to content

[10387] Update Performance Throughput Testing to support: data sharing, loans and zero copy #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 23, 2021
Merged

[10387] Update Performance Throughput Testing to support: data sharing, loans and zero copy #1759

merged 31 commits into from
Feb 23, 2021

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Feb 14, 2021 •
edited by MiguelCompany
Loading

This pull request includes the changes of #1753 (updates to use DDS API, update the data type to allow for loans), and also new parameters to the tool indicating that is should use the loans APIs

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the feature/performance_throughput_zero_copy branch from 0cc1ae4 to 3ebcc22 Compare February 15, 2021 10:00
@MiguelBarro MiguelBarro added the skip-ci Automatically pass CI label Feb 15, 2021
@MiguelBarro MiguelBarro force-pushed the feature/performance_throughput_zero_copy branch from 3ebcc22 to b0619cb Compare February 15, 2021 11:19
@MiguelBarro MiguelBarro changed the title Update Performance Throughput Testing to support: data sharing, loans and zero copy [10387] Update Performance Throughput Testing to support: data sharing, loans and zero copy Feb 15, 2021
@MiguelBarro MiguelBarro force-pushed the feature/performance_throughput_zero_copy branch from b0619cb to 2012be8 Compare February 15, 2021 11:31
@MiguelBarro MiguelBarro removed the skip-ci Automatically pass CI label Feb 15, 2021
@MiguelBarro MiguelBarro force-pushed the feature/performance_throughput_zero_copy branch 2 times, most recently from 50b9160 to 974d725 Compare February 15, 2021 20:33
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the feature/performance_throughput_zero_copy branch 2 times, most recently from 097ec3f to 10a7163 Compare February 16, 2021 06:47
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro
Copy link
Contributor Author

Linux aarch64 shows a non related issue. See a succesful run in linux aarch 960

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro
Copy link
Contributor Author

MiguelBarro commented Feb 18, 2021 •
edited
Loading

All test failures are unrelated but the Mac one.
The performance.throughput.intraprocess_reliable.data_loans_and_sharing failed because cannot allocate the Shared memory segment in the second iteration (1kB, 1000). All other tests were able to make this allocation and the larger one (16kb, 1000).
I rerun Mac and pass without failures Mac manual

@MiguelCompany MiguelCompany mentioned this pull request Feb 19, 2021
Closed
IkerLuengo
IkerLuengo suggested changes Feb 19, 2021
View reviewed changes
Miguel Barro and others added 11 commits February 20, 2021 10:12
Updating test DataType to make it loan friendly
c396ba2
Refs #10386: Updated ThroughputPublisher to the new DDS API
eb4b825
Use xml to load qos in order to modify them later
deaf7bb
@JLBuenoLopez
Refs #10386: fix build in gcc. Include order and remove using std in …
a8eda81 
…Publisher.

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #10386: remove PSM header from Subscriber
1426311 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #10386: partial refactor Subscriber to DDS API
c78a79e 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Refs #10386: Upgrading ThroughputSubscriber to new DDS api
4178b34
Command logic modified to account for new static type management
1e36a8e
Solving cl building issues
da148fe
Solving sync issues on Subscriber callbacks
11b539d
Serialized endpoint liveliness in intraprocess
f6abfcb
Miguel Barro added 19 commits February 20, 2021 10:12
Disabling data sharing in xmls
aded1e6
linter pass
4d79865
Replacing data endpoint removal sync from a wait based on unmatch to …
4d0e33e 
…a devoted message. In intraprocess unmatching doesn't mean complete endpoint removal on reception.
Updating the demands file parsing to account for the new Type overhead
29088fd
Update CMakeLists.txt to include data sharing and loans.
4f0c68e
Update python script to include data sharing and loans.
4e54823
Updated test binary cli to support data sharing and loans
d708ee8
Data sharing implementation
a224635
Data loans implementation
37713b8
Linter pass
597b213
Reduce testing memory footprint to avoid linux dockers constrains
120379f
Fall back to udp discovery in all tests to prevent discovery issues.
59da480
Restrain domain ids below 100 to avoid multicast issues on windows.
5d627c1
workaround 'linux pure virtual method called' exception
943942a
Enforce atomic barrier to disable callbacks
4cf377d
Disabling security settings for non security builds
e806dd0
Give some room to the DataSharingListener to process all data before …
5e5a546 
…destroying endpoints
Reset the Data QoS in each Type iteration
5e64b3f
Addressing reviewers comments
65e3464
@MiguelBarro MiguelBarro force-pushed the feature/performance_throughput_zero_copy branch from b31661f to 65e3464 Compare February 20, 2021 09:51
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

IkerLuengo
IkerLuengo previously approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelBarro MiguelBarro added the skip-ci Automatically pass CI label Feb 22, 2021
@EduPonz EduPonz merged commit c886be4 into master Feb 23, 2021
@EduPonz EduPonz deleted the feature/performance_throughput_zero_copy branch February 23, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

@IkerLuengo IkerLuengo IkerLuengo left review comments

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MiguelBarro @richiprosima @EduPonz @IkerLuengo @JLBuenoLopez